Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commit version after every migration instead of all at once #1566

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Nov 9, 2023

Motivation

This means we don't migrations when a one of them fails within a batch.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

This PR focuses on adding a new function getDbSchemaVersion and refactoring the code to use it.

Detailed summary

  • Added getDbSchemaVersion function to retrieve the schema version from the database.
  • Refactored code to use getDbSchemaVersion instead of this.getDbSchemaVersion.
  • Removed getDbSchemaVersion and setDbSchemaVersion functions from the Hub class.
  • Updated tests to use getDbSchemaVersion function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-bug A fix for a bug with the current system label Nov 9, 2023
Copy link

changeset-bot bot commented Nov 9, 2023

⚠️ No Changeset found

Latest commit: db6e2ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 6:06pm

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
apps/hubble/src/hubble.ts 52.97% <100.00%> (-0.56%) ⬇️
...pps/hubble/src/storage/db/migrations/migrations.ts 88.37% <85.00%> (-2.94%) ⬇️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@sanjayprabhu sanjayprabhu merged commit ff5a90c into farcasterxyz:main Nov 9, 2023
9 checks passed
@sanjayprabhu sanjayprabhu deleted the step_migrations branch November 9, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-bug A fix for a bug with the current system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant