Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Minor cleanup #1570

Merged
merged 4 commits into from
Dec 4, 2023
Merged

chore: Minor cleanup #1570

merged 4 commits into from
Dec 4, 2023

Conversation

sanjayprabhu
Copy link
Contributor

@sanjayprabhu sanjayprabhu commented Nov 9, 2023

Motivation

  • Add some helpers to console
  • Remove some sync optimizations for hubs that haven't migrated yet.
  • Reduce contact info logging noise
  • Remove v2 contract address cli flags

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers


PR-Codex overview

Detailed summary

  • Renamed and removed v2 contract address CLI parameters after migration
  • Removed unused variable blockNumber in multiPeerSyncEngine.test.ts
  • Added toFarcasterTime and fromFarcasterTime functions in console.ts
  • Added SyncId class in console.ts
  • Updated Hub class to use new contract address options
  • Updated CLI options for contract addresses in cli.ts
  • Updated app configuration in cli.ts to use new contract address options
  • Updated logging level in syncEngine.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@sanjayprabhu sanjayprabhu added the t-chore Miscellaneous improvements label Nov 9, 2023
Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 54a3558

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@farcaster/hubble Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2023 6:34pm

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dd49ac) 73.33% compared to head (54a3558) 73.93%.
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1570      +/-   ##
==========================================
+ Coverage   73.33%   73.93%   +0.59%     
==========================================
  Files          92       98       +6     
  Lines        8634     8892     +258     
  Branches     1946     1971      +25     
==========================================
+ Hits         6332     6574     +242     
- Misses       2184     2201      +17     
+ Partials      118      117       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayprabhu sanjayprabhu merged commit 20b6575 into farcasterxyz:main Dec 4, 2023
9 checks passed
@sanjayprabhu sanjayprabhu deleted the cleanup branch December 4, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-chore Miscellaneous improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant