Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add EIP-712 helpers #1587

Merged
merged 6 commits into from
Nov 27, 2023
Merged

feat: add EIP-712 helpers #1587

merged 6 commits into from
Nov 27, 2023

Conversation

horsefacts
Copy link
Contributor

@horsefacts horsefacts commented Nov 21, 2023

Motivation

Add helper functions for creating and verifying EIP-712 signatures related to the new contracts.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

Focus of the PR:

This PR adds EIP-712 helpers and updates the contracts and signers in the core Ethereum module.

Detailed summary:

  • Added EIP-712 helpers for IdGateway, KeyRegistry, SignedKeyRequestValidator, and KeyGateway.
  • Updated contracts: bundler, idGateway, keyRegistry, signedKeyRequestValidator, and keyGateway.
  • Updated the Eip712Signer class in the core module.

The following files were skipped due to too many changes: packages/core/src/eth/contracts/abis/bundler.ts, packages/core/src/eth/contracts/idRegistry.ts, packages/core/src/eth/contracts/abis/signedKeyRequestValidator.ts, packages/core/src/signers/ethersV5Eip712Signer.ts, packages/core/src/signers/ethersEip712Signer.ts, packages/core/src/signers/viemLocalEip712Signer.ts, packages/core/src/eth/contracts/abis/keyGateway.ts, packages/core/src/eth/contracts/abis/idGateway.ts, packages/core/src/signers/testUtils.ts, packages/core/src/eth/contracts/abis/idRegistry.ts, packages/core/src/eth/contracts/abis/keyRegistry.ts, packages/core/src/eth/contracts/abis/storageRegistry.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: f1b84f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@farcaster/core Patch
@farcaster/hub-nodejs Patch
@farcaster/hub-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 10:11pm

@horsefacts horsefacts added the t-feat Add a new feature or protocol improvement label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (f026ad1) 73.34% compared to head (f1b84f1) 73.68%.

Files Patch % Lines
packages/core/src/eth/contracts/idRegistry.ts 85.00% 3 Missing ⚠️
packages/core/src/signers/ethersEip712Signer.ts 93.18% 3 Missing ⚠️
packages/core/src/signers/ethersV5Eip712Signer.ts 93.18% 3 Missing ⚠️
packages/core/src/signers/viemLocalEip712Signer.ts 93.18% 3 Missing ⚠️
packages/core/src/eth/contracts/idGateway.ts 87.50% 1 Missing ⚠️
packages/core/src/eth/contracts/keyGateway.ts 87.50% 1 Missing ⚠️
packages/core/src/eth/contracts/keyRegistry.ts 87.50% 1 Missing ⚠️
...ore/src/eth/contracts/signedKeyRequestValidator.ts 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1587      +/-   ##
==========================================
+ Coverage   73.34%   73.68%   +0.34%     
==========================================
  Files          92       97       +5     
  Lines        8636     8820     +184     
  Branches     1946     1958      +12     
==========================================
+ Hits         6334     6499     +165     
- Misses       2184     2203      +19     
  Partials      118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@horsefacts horsefacts force-pushed the horsefacts/eip-712-helpers branch from 8282760 to f1b84f1 Compare November 27, 2023 22:10
@horsefacts horsefacts merged commit ab245ce into main Nov 27, 2023
9 checks passed
@horsefacts horsefacts deleted the horsefacts/eip-712-helpers branch November 27, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-feat Add a new feature or protocol improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant