fix: Don't add deleted fnames to sync trie

[sanjayprabhu]

Motivation

We were adding deleted fnames to the trie which cases sync loops since they don't actually exist in the db. Check if fid is 0 and skip adding the deletes.

Change Summary

Describe the changes being made in 1-2 concise sentences.

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review

• PR title adheres to the conventional commits standard
• PR has a changeset
• PR has been tagged with a change label(s) (i.e. documentation, feature, bugfix, or chore)
• PR includes documentation if necessary.
• All commits have been signed

Additional Context

If this is a relatively large or complex change, provide more details here that will help reviewers

---

PR-Codex overview

Focus of the PR:

Fixing an issue where deleted fnames were being added to the sync trie.

Detailed summary:

• Modified syncEngine.ts to check if the fid of the usernameProof is not 0 before adding it to the sync trie.
• Added a test in syncEngine.test.ts to verify that a deleted fname is not added to the trie.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
hub-monorepo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 11, 2024 0:56am

[changeset-bot]

🦋 Changeset detected

Latest commit: 79bb27b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@farcaster/hubble	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR