-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create FrameAction message and add validation endpoint #1632
Conversation
🦋 Changeset detectedLatest commit: bee38aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
c202cfe
to
e9537a4
Compare
e9537a4
to
6b687c0
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
=========================================
+ Coverage 0 73.81% +73.81%
=========================================
Files 0 99 +99
Lines 0 9000 +9000
Branches 0 1998 +1998
=========================================
+ Hits 0 6643 +6643
- Misses 0 2239 +2239
- Partials 0 118 +118 ☔ View full report in Codecov by Sentry. |
protobufs/schemas/message.proto
Outdated
/** A Farcaster Frame action */ | ||
message FrameActionBody { | ||
bytes url = 1; // URL of the Frame triggering the action | ||
bytes button_id = 2; // The identifier of the button pressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be button_index for now
193fb02
to
bee38aa
Compare
Motivation
Add support for a FrameAction message type. And add a validateMessage endpoint that can use used to validate them. FrameActions are not stored on the hub and submitMessage will reject them.
Change Summary
Support Farcaster Frames
Merge Checklist
Choose all relevant options below by adding an
x
now or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
This PR focuses on adding support for FrameAction messages and introducing a new validation method for messages.
Detailed summary
FrameAction
message type to therequest_response.proto
schemavalidateMessage
method inutil.ts
andhubble.ts
FrameActionBody
message type to themessage.proto
schemamakeFrameAction
andmakeFrameActionData
functions inbuilders.ts
validateFrameActionBody
function invalidations.ts
index.ts
andindex.test.ts
to handleFrameAction
messagesserver.ts
to handlevalidateMessage
RPC call in the Hub serverValidationResponse
message type to theserver.ts
schemahttpServer.ts
to handlevalidateMessage
API endpoint