fix: Reduce sync frequency #1648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6d2aa74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sanjayprabhu
force-pushed
the
reduce_sync_frequency
branch
from
f2893ac to
6d2aa74
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
==========================================
- Coverage 73.85% 73.78% -0.07%
==========================================
Files 99 99
Lines 9010 9007 -3
Branches 2001 2000 -1
==========================================
- Hits 6654 6646 -8
- Misses 2238 2243 +5
Partials 118 118 ☔ View full report in Codecov by Sentry. |
sanjayprabhu
commented
Feb 3, 2024
| // Temporarily disable sync with new peers | ||
| log.debug({ peerInfo: message }, "New peer but skipping sync"); | ||
| // const syncResult = await ResultAsync.fromPromise( | ||
| // this.syncEngine.diffSyncIfRequired(this, peerId.toString()), |
There was a problem hiding this comment.
We should only be syncing the last ~ hour-days worth of messages here. Anything longer should happen in the sync job.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hubs are under significant load, we're syncing too often. Reducing sync frequency should help.
Will look into switching to probabilistic syncing across different time frames (higher frequency for recent timeframes and lower frequency for longer timeframes).
Change Summary
Describe the changes being made in 1-2 concise sentences.
Merge Checklist
Choose all relevant options below by adding an
xnow or at any time before submitting for reviewAdditional Context
If this is a relatively large or complex change, provide more details here that will help reviewers
PR-Codex overview
This PR reduces the sync frequency of the Hubble app to help reduce the load on the hub.
Detailed summary
PeriodicSyncJobScheduler.hubble.tsfile.