Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make stream message buffer size configurable via CLI #2473

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

@VolodymyrBg VolodymyrBg commented Jan 15, 2025

Why is this change needed?

  • Add --stream-message-buffer-size CLI option to configure the maximum number of messages to buffer when a stream is backed up
  • Default value remains at 10,000 messages
  • Resolves TODO in bufferedStreamWriter.ts

Merge Checklist

Choose all relevant options below by adding an x now or at any time before submitting for review


PR-Codex overview

This PR introduces a new command-line option for configuring the stream message buffer size and updates the BufferedStreamWriter class to utilize this configurable buffer size instead of a hardcoded value.

Detailed summary

  • Added --stream-message-buffer-size <number> option to set the maximum number of messages to buffer.
  • Renamed STREAM_MESSAGE_BUFFER_SIZE to DEFAULT_STREAM_MESSAGE_BUFFER_SIZE for clarity.
  • Updated BufferedStreamWriter constructor to accept an optional bufferSize parameter.
  • Changed buffer size check in writeToStream method to use the new bufferSize property.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

- Add --stream-message-buffer-size CLI option to configure the maximum number of messages to buffer when a stream is backed up
- Default value remains at 10,000 messages
- Resolves TODO in bufferedStreamWriter.ts
Copy link

changeset-bot bot commented Jan 15, 2025

⚠️ No Changeset found

Latest commit: 80c9ad3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hub-monorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 8:26pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant