-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): simplify how some dependencies are fetched #221
base: main
Are you sure you want to change the base?
Conversation
I was browsing around and saw that #184 was in the work, feel free to close this if you don't need it then :) |
I watched the changes made in #225 and wanted to further simplify your pipeline. Now that Cargo handles the download of the repo & the version, your build actions should be much easier to write. I hope this is useful :) EDIT: would you like me to make changes to the GitHub actions to delete the checkout steps? (and also the Dockerfile) |
Malachite packages were published. Probably can close this PR. |
You're right, my PR should be edited to account for the release of Malachite. However, some changes are still relevant today: I can understand this is not the priority ATM tho! |
This PR is a mess I need to maintain as the changes drop but I've been underwater lately ;) |
Summary of the changes
config.toml
to use a git repository with a commit hash and a package specifier (telling Cargo where to look for stuff)cargo.lock
was updated when I pulled dependencies after my changesGoals
Hope this will be useful <3