fix: handle empty byte slices (#5)

fardream · Jun 11, 2024 · ec0fc22 · ec0fc22
1 parent 3e4ac04
commit ec0fc22
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/bcs/decode.go b/bcs/decode.go
@@ -264,6 +264,10 @@ func (d *Decoder) decodeByteSlice(v reflect.Value) (int, error) {
 		return n, err
 	}
 
+	if size == 0 {
+		return n, nil
+	}
+
 	tmp := make([]byte, size)
 
 	read, err := d.reader.Read(tmp)

diff --git a/bcs/decode_test.go b/bcs/decode_test.go
@@ -154,3 +154,18 @@ func TestUnmarshal(t *testing.T) {
 		}
 	}
 }
+
+func TestEmptyByteSlice(t *testing.T) {
+	encoded, err := bcs.Marshal([]byte{})
+	if err != nil {
+		t.Error(err)
+	}
+	decoded := new([]byte)
+	n, err := bcs.Unmarshal(encoded, decoded)
+	if err != nil {
+		t.Error(err)
+	}
+	if n != 1 {
+		t.Errorf("want parsed length 1")
+	}
+}