Add support for Django 5.1 by removing deprecated features #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farridav
reviewed
Mar 23, 2024
jamesgilmorelyst
force-pushed
the
fix-django-RemovedInDjango51Warning
branch
from
1976c27
to
bb214e9
Compare
jamesgilmorelyst
changed the title
|
Hi @farridav, sorry to be a pain, but I've migrated my GH account from my work to personal account so I can continue to make contributions for as long as possible. Would it be okay to help contribute/maintain from my current account instead, please? |
|
Sure, makes sense |
PacificGilly
force-pushed
the
fix-django-RemovedInDjango51Warning
branch
from
bb214e9
to
24462df
Compare
|
Hey, just a headsup django just release the stable 5.1 so would be lovely if tihs PR could be merged soonish and a new version release. Thanks for all the awesome work, much much appreciated 😊 |
PacificGilly
force-pushed
the
fix-django-RemovedInDjango51Warning
branch
from
24462df
to
80dccb1
Compare
|
would love to see this merged in - this is now a blocking issue on a fresh Django project |
There is only one Django feature used here that is removed in >=5.0 which is the `length_is` filter query:
```
RemovedInDjango51Warning: The length_is template filter is deprecated in favor of the length template filter and the == operator within an {% if %} tag.
```
A trivial change to make and the `length` feature if backwards compatile to the earliest support version this repo supports of 2.2.
The documentation was really easy to follow, but noticed that these comamnds for setting up the test app was already defined in the Makefile, so just repointed the development documentation to use the Make command instead.
PacificGilly
force-pushed
the
fix-django-RemovedInDjango51Warning
branch
from
80dccb1
to
913e795
Compare
|
already resolved in v.3.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one Django feature used here that is removed in >=5.0, which is the
length_isfilter query:It is a trivial change to make, and the
lengthfeature if backwards compatible to the earliest support version this repo supports of 2.2.Preview of
fieldsets, which has been modified in this PR:As this is my first PR, I've also added in some QoL changes for new devs working in this repo. Hopefully that's okay 🙂