Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues in existing services #24

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

bedrock-adam
Copy link
Contributor

@bedrock-adam bedrock-adam commented Mar 22, 2024

  • ensure all queries wrapped in connection pool block
  • ensure all queries wrapped in transaction block
  • ensure no AR models are returned (just hashes with id)

@bedrock-adam bedrock-adam changed the title refactor: existing services refactor existing services Mar 22, 2024
@bedrock-adam bedrock-adam changed the title refactor existing services fix issues in existing services Mar 22, 2024
@bedrock-adam bedrock-adam merged commit 974ff0a into master Mar 22, 2024
1 check passed
@bedrock-adam bedrock-adam deleted the spike/refactored_services branch March 22, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant