-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of missing date attribute for velocity profiles #4
Open
tbartholomaus
wants to merge
1
commit into
fastice:master
Choose a base branch
from
tbartholomaus:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call to `myVelSeries.plotProfile` in the example workingWithGrIMPVelocity.ipynb was missing use of a `date` attribute, which caused example plot to repeatedly plot only one date. Small correction to that here, as well as a tweak to the language describing the plot.
I think this was fixed last week. Try downloading latest commit. IanIan JoughinPolar Science CenterApplied Physics LabU Washington206-221-3177On Dec 3, 2022, at 1:58 PM, Timothy Bartholomaus ***@***.***> wrote:Call to myVelSeries.plotProfile in the example workingWithGrIMPVelocity.ipynb was missing use of a date attribute, which caused example plot to repeatedly plot only one date. Small correction to that here, as well as a tweak to the language describing the plot.
You can view, comment on, or merge this pull request online at:
#4
Commit Summary
08e9f77 Addition of missing dates for profiles
File Changes (1 file)
M
workingWithGrIMPVelocity.ipynb
(4)
Patch Links:
https://github.com/fastice/GrIMPNotebooks/pull/4.patch
https://github.com/fastice/GrIMPNotebooks/pull/4.diff
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
I'm impressed you're trying to resolve pull requests on your phone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to
myVelSeries.plotProfile
in the example workingWithGrIMPVelocity.ipynb was missing use of adate
attribute, which caused example plot to repeatedly plot only one date. Small correction to that here, as well as a tweak to the language describing the plot.