Periodic Reauthentication #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test_chewie.py:test_port_status_changes() blocks forever. |
|
Skipping broken test, test_chewie.py:test_port_status_changes() Not particularly sure how to fix it atm. Will have another look tomorrow morning if at work (coming down with man flu). The case should be tested over on the faucet integration tests, so could potentially be merged, (i don't mind either way). |
|
Hi @Bairdo, just letting you know we are deferring the faucet 1.9 release until tomorrow now. On the off chance you are feeling better you have an extra day to get all this wrapped up. Otherwise we can include it in next weeks release. |
… requests after port up if no one 'active' on port
gizmoguy
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builds on top of #116.