Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tls client test #760

Merged
merged 6 commits into from
Feb 8, 2021
Merged

Tls client test #760

merged 6 commits into from
Feb 8, 2021

Conversation

jhughesbiot
Copy link
Collaborator

This PR partially addresses the issue reported here #655 for TLS 1.2. Currently there is no TLS 1.3 failure criteria defined so additional failure criteria will need to be created for TLS 1.3 outbound connections for this test to properly simulate failures.

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #760 (08212ab) into master (55c7438) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   82.04%   82.06%   +0.02%     
==========================================
  Files          30       30              
  Lines        4371     4371              
==========================================
+ Hits         3586     3587       +1     
+ Misses        785      784       -1     
Flag Coverage Δ
aux 73.87% <ø> (-0.03%) ⬇️
base 76.26% <ø> (-0.05%) ⬇️
dhcp 72.69% <ø> (ø)
many 72.69% <ø> (-0.05%) ⬇️
topo 71.52% <ø> (-0.10%) ⬇️
unit 26.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/runner.py 87.68% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55c7438...08212ab. Read the comment docs.

@jhughesbiot jhughesbiot requested review from grafnu and pisuke February 3, 2021 05:23
@jhughesbiot
Copy link
Collaborator Author

@grafnu @pisuke
I know this has been approved but I do not appear to have access to merge.

@grafnu grafnu merged commit f5e14d4 into faucetsdn:master Feb 8, 2021
@grafnu
Copy link
Collaborator

grafnu commented Feb 8, 2021

@grafnu @pisuke
I know this has been approved but I do not appear to have access to merge.

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants