Update NTP tests to use hostname #862
Conversation
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
- Coverage 81.90% 81.77% -0.14%
==========================================
Files 43 43
Lines 5273 5398 +125
==========================================
+ Hits 4319 4414 +95
- Misses 954 984 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
docker/include/bin/start_faux
Outdated
| # NTPv3 query to the IP of time.google.com (since resolv.conf is modified by other tests) | ||
| if [ -n "${options[ntpv4]}" ]; then | ||
| dhcp_ntp=$(fgrep NTPSERVERS= /run/ntpdate.dhcp) | ||
| ntp_server=`echo $dhcp_ntp | cut -d "'" -f 2` | ||
| ntp_server=ntp.daqlocal |
There was a problem hiding this comment.
since ntp.daqlocal is used a couple of times, make it a named variable in this file? (LOCAL_NTP_SERVER_NAME=ntp.daqlocal or something like that)
| ip addr add 10.20.$subnet.2 dev $LOCAL_IF | ||
| echo dhcp-option=6,10.20.$subnet.2 >> /etc/dnsmasq.conf | ||
| echo dhcp-option=42,10.20.$subnet.2 >> /etc/dnsmasq.conf |
There was a problem hiding this comment.
Should we delete this? Leaving this in place would allow the DUT to either learn NTP from DHCP option, or have it statically configured, so we'll cover both options?
There was a problem hiding this comment.
Yes, on the issue #845 there's been additional comments from Trevor, as well as your comment from last week on having both test cases, so this PR will be updated accordingly
Additional discussion on issue #845
Updates the NTP tests to use the hostname rather than DHCP by adding a hostname
ntp.daqlocaland the NTP server IP address from DHCP