Enable CI tests for discovery node #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noursaidi
commented
Dec 9, 2024
| @@ -148,13 +150,53 @@ jobs: | |||
| env: | |||
| IMAGE_NAME: ${{ github.repository }} | |||
| REF_NAME: ${{ github.ref_name }} | |||
| DEVICE_ID: ${{'AHU-1'}} | |||
noursaidi
commented
Dec 9, 2024
| run: | | ||
| docker run --net udminet --name registrar -v $(realpath site_model):/root/site_model \ | ||
| ghcr.io/$IMAGE_NAME:validator-$REF_NAME bin/registrar site_model/cloud_iot_config.json | ||
| - name: Start discoverynode | ||
| run: | | ||
| export IMAGE_TAG=ghcr.io/$IMAGE_NAME:misc-$REF_NAME | ||
| # This currently fails (no config), but just check that it actually runs. |
grafnu
approved these changes
Dec 9, 2024
| @@ -11,8 +11,8 @@ ROOT_DIR=$(realpath $(dirname $0)/..) | |||
| BASE_CONFIG=$(realpath $ROOT_DIR/etc/base_config.json) | |||
| TMP_CONFIG="/tmp/discoverynode_config.json" | |||
|
|
|||
| if [[ $# -ne 3 ]]; then | |||
| error Usage: $0 SITE_MODEL TARGET DEVICE_ID | |||
| if (( $# -le 4 )); then | |||
There was a problem hiding this comment.
shouldn't this be -le 2 since the [OPTIONS] bit is optional? Or -lt 3?
There was a problem hiding this comment.
There's three required options:
- site model
- target
- device ID
misc/discoverynode/bin/run
Outdated
|
|
||
| cat $TMP_CONFIG | jq -r "$substitutions" | sponge $TMP_CONFIG | ||
|
|
||
| for option in "$@" |
There was a problem hiding this comment.
convention is to have "; do" at the end, rather than "do" on a new line
|
Yes, and if so, you would have (( 3 -le 4 )); then error?
…On Tue, Dec 10, 2024 at 1:43 AM Noureddine ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In misc/discoverynode/bin/run
<#1047 (comment)>:
> @@ -11,8 +11,8 @@ ROOT_DIR=$(realpath $(dirname $0)/..)
BASE_CONFIG=$(realpath $ROOT_DIR/etc/base_config.json)
TMP_CONFIG="/tmp/discoverynode_config.json"
-if [[ $# -ne 3 ]]; then
- error Usage: $0 SITE_MODEL TARGET DEVICE_ID
+if (( $# -le 4 )); then
There's three required options:
- site model
- target
- device ID
—
Reply to this email directly, view it on GitHub
<#1047 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPDZTVI7WHKBA2HOJPSL2E2ZSXAVCNFSM6AAAAABTJUVYCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOJRGY4TAOBXGQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
what's the status of this? Submit? Draft? Close? |
|
in progress, there's some peculiar auth bug in the non integration test environment so I'm just going to split the PR so the working integration test can be merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.