ENG-6200: Turn client timeout into a response header timeout #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnwpedro
requested changes
Apr 22, 2024
erickpintor
force-pushed
the
streaming-http-timeout
branch
from
6bc1e60 to
3e76a79
Compare
pnwpedro
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go's HTTP client timeout comprehends both getting the response headers and reading its body. However, for streaming, the HTTP body will never stop coming until there's a network error or the connection is closed. Moreover, normal on queries, if the body was produced by the server, it's on the client's best interest to receive it, IMO. Therefore, I'm proposing that we change the timeout handling to the transport's response header timeout so that we can use the same client for both query and streaming.