Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new response types #119

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Use new response types #119

merged 1 commit into from
Aug 26, 2024

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Aug 26, 2024

Description

  • Use new response models with custom deserializers
  • Update (simplify!) response building
  • Handle non-string abort data
  • Handle non-string constraint paths

Motivation and context

BT-5043

  • We want to eliminate messing around with json nodes because it's messy and avoid parsing the whole response and reserializing the parts we care about. We were doing it because we needed part of the json tree to go unparsed, but there are ways of doing this via custom deserializers for jackson.
  • We weren't handling complex abort data and integer value paths in constraint failures.

How was the change tested?

  • Updated existing tests
  • Added new tests

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

findgriffin
findgriffin previously approved these changes Aug 26, 2024
Base automatically changed from new-types-and-deser to main August 26, 2024 18:18
@pnwpedro pnwpedro dismissed findgriffin’s stale review August 26, 2024 18:18

The base branch was changed.

@pnwpedro pnwpedro requested a review from findgriffin August 26, 2024 18:33
@findgriffin findgriffin merged commit 7b2ff87 into main Aug 26, 2024
1 check passed
@findgriffin findgriffin deleted the use-new-resp-types branch August 26, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants