Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cleaner impl for query tags deser #120

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Use cleaner impl for query tags deser #120

merged 2 commits into from
Aug 26, 2024

Conversation

pnwpedro
Copy link
Collaborator

Description

  • Improve the query tags deserializer implementation

Motivation and context

BT-5043

How was the change tested?

  • Existing tests pass

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro requested a review from findgriffin August 26, 2024 18:38
@pnwpedro pnwpedro force-pushed the improv-query-tags-deser branch from f3ffb9a to 86fb75f Compare August 26, 2024 18:41
findgriffin
findgriffin approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@findgriffin findgriffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is pretty much what I meant.

@findgriffin findgriffin merged commit 9ad8181 into main Aug 26, 2024
1 check passed
@findgriffin findgriffin deleted the improv-query-tags-deser branch August 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findgriffin findgriffin findgriffin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnwpedro @findgriffin