Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle super fields class codec #127

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Handle super fields class codec #127

merged 1 commit into from
Sep 4, 2024

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Sep 4, 2024

Description

  • Obtain fields from all super classes in the ClassCodec

Motivation and context

BT-5092

Class inheritance is not handled in the ClassCodec.

How was the change tested?

  • Added unit test

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro changed the base branch from main to id-coll-ts-annotations September 4, 2024 11:26
@pnwpedro pnwpedro force-pushed the handle-super-fields-class-codec branch from a627015 to 0579726 Compare September 4, 2024 14:53
findgriffin
findgriffin previously approved these changes Sep 4, 2024
View reviewed changes
Base automatically changed from id-coll-ts-annotations to main September 4, 2024 17:50
@pnwpedro pnwpedro dismissed findgriffin’s stale review September 4, 2024 17:50

The base branch was changed.

@pnwpedro pnwpedro requested a review from findgriffin September 4, 2024 17:50
@pnwpedro pnwpedro merged commit 4bfaa89 into main Sep 4, 2024
1 check passed
@pnwpedro pnwpedro deleted the handle-super-fields-class-codec branch September 4, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@findgriffin findgriffin findgriffin approved these changes

@freels freels Awaiting requested review from freels

@erickpintor erickpintor Awaiting requested review from erickpintor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnwpedro @findgriffin