Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: update define class content #133

Merged
merged 13 commits into from
Sep 10, 2024
Merged

README: update define class content #133

merged 13 commits into from
Sep 10, 2024

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Sep 9, 2024

Description

Get the readme ready for a beta release

Motivation and context

Because it has to be right! And good!

How was the change tested?

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro requested a review from jrodewig September 9, 2024 15:52
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pnwpedro Left some feedback. I'll push some changes for streaming shortly.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jrodewig
Copy link
Contributor

jrodewig commented Sep 9, 2024

On second thought, I'll open a separate PR to handle streaming. Thanks!

@pnwpedro
Copy link
Collaborator Author

pnwpedro commented Sep 9, 2024

On second thought, I'll open a separate PR to handle streaming. Thanks!

okay np. i was thinking we'd queue up one big readme update and merge it during release. smaller is fine, but we prob want to set the default branch on the repo to the most recent release branch so users see the relevant readme when they come here

@jrodewig
Copy link
Contributor

jrodewig commented Sep 9, 2024

On second thought, I'll open a separate PR to handle streaming. Thanks!

okay np. i was thinking we'd queue up one big readme update and merge it during release. smaller is fine, but we prob want to set the default branch on the repo to the most recent release branch so users see the relevant readme when they come here

Ah — I'll push my changes here then. Added with 913201e (#133)

findgriffin
findgriffin previously approved these changes Sep 9, 2024
@findgriffin findgriffin marked this pull request as ready for review September 9, 2024 20:37
findgriffin and others added 5 commits September 9, 2024 13:38
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
jrodewig
jrodewig previously approved these changes Sep 9, 2024
findgriffin
findgriffin previously approved these changes Sep 9, 2024
jrodewig
jrodewig previously approved these changes Sep 10, 2024
jrodewig
jrodewig previously approved these changes Sep 10, 2024
jrodewig
jrodewig previously approved these changes Sep 10, 2024
@findgriffin findgriffin merged commit 3b6ad7b into main Sep 10, 2024
1 check passed
@findgriffin findgriffin deleted the beta-readme branch September 10, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants