[BT-5096] Refactor client exceptions. #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findgriffin
changed the base branch from
main
to
BT-5084-streaming-edge-cases
jdcryans
previously approved these changes
Sep 10, 2024
pnwpedro
previously approved these changes
Sep 11, 2024
findgriffin
dismissed stale reviews from pnwpedro and jdcryans
The base branch was changed.
Co-authored-by: Lucas Pedroza <[email protected]>
pnwpedro
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds three new exception types
ClientRequestException,ClientResponseException, andCodecExceptionand uses them throughout encoding and decoding.Motivation and context
Allows the client and users to figure out what went wrong.
How was the change tested?
Lots of unit test changes, but I'm sure we could further increase coverage.
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.