Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make obj/arr encoding more restrictive #139

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Sep 11, 2024

Description

  • Make QueryObj only accept Map<String,E extends QueryFragment>
  • Make QueryArr only accept List<E extends QueryFragment>

Motivation and context

QueryObj and QueryArr handle special cases where a user wants Fauna to evaluate sub queries at runtime as either values or elements respectively. This requires special encoding, and so all values/elements must be QueryFragments.

How was the change tested?

Tests updated

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pnwpedro pnwpedro merged commit fae90d5 into main Sep 11, 2024
1 check passed
@pnwpedro pnwpedro deleted the fix-obj-arr-encoding branch September 11, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants