Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT-5120-pagination-ergonomics] Implement queryPage and asyncQueryPage APIs.. #149

Merged
merged 1 commit into from
Sep 25, 2024

Conversation

findgriffin
Copy link
Contributor

@findgriffin findgriffin commented Sep 23, 2024

Description

I added two new methods to FaunaClient along with some refactoring of the error handling. Note that I did not add the full complement of methods with/without QueryOptions and elementClass because I think there are already a lot of methods on FaunaClient.

Note that changing the signature of Page.getAfter from Optional<String> to Optional<AfterToken> is technically a breaking change, but I think this is OK since we are still in beta.

Motivation and context

The feature request was driven by trying to implement a RESTful API in the sample app.

How was the change tested?

There was already a nice E2E test to modify, several unit tests check that we didn't accidentally change the exception handling.

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • [?] My change requires a change to Fauna documentation.
    • [?] My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@findgriffin findgriffin merged commit a9ffe95 into main Sep 25, 2024
1 check passed
@findgriffin findgriffin deleted the BT-5120-pagination-ergonomics branch September 25, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants