[BT-5120-pagination-ergonomics] Implement queryPage and asyncQueryPage APIs.. #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added two new methods to
FaunaClient
along with some refactoring of the error handling. Note that I did not add the full complement of methods with/withoutQueryOptions
andelementClass
because I think there are already a lot of methods onFaunaClient
.Note that changing the signature of
Page.getAfter
fromOptional<String>
toOptional<AfterToken>
is technically a breaking change, but I think this is OK since we are still in beta.Motivation and context
The feature request was driven by trying to implement a RESTful API in the sample app.
How was the change tested?
There was already a nice E2E test to modify, several unit tests check that we didn't accidentally change the exception handling.
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.