[BT-5174-http-timeout] Allow user-configurable HTTP timeout for query and stream requests. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnwpedro
previously requested changes
Oct 10, 2024
findgriffin
requested review from
pnwpedro,
cynicaljoy and
a team
and removed request for
cynicaljoy
jdcryans
reviewed
Oct 15, 2024
jdcryans
reviewed
Oct 16, 2024
| @@ -63,6 +66,14 @@ public int getMaxContentionRetries() { | |||
| return maxContentionRetries; | |||
| } | |||
|
|
|||
| /** | |||
| * | |||
jdcryans
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added support for setting the HttpClient timeout (HttpClient connect timeout, and Fauna query are already configurable).
Motivation and context
I noticed this when testing logging support on Monday. It seems minor, but could also be frustrating for customers if we don't support it.
How was the change tested?
Unit and E2E tests.
Screenshots (if appropriate):
Change types
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.