Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add javadocs for QueryStats #170

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Add javadocs for QueryStats #170

merged 2 commits into from
Nov 6, 2024

Conversation

pnwpedro
Copy link
Collaborator

@pnwpedro pnwpedro commented Nov 6, 2024

Description

  • Modifies QueryStats and QueryStatsSummary to adhere to our checkstyle config.
  • Adds a package-info.java for the two packages touched.

Motivation and context

BT-5258

How was the change tested?

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

jrodewig
jrodewig previously approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Left some non-blocking suggestions. Thanks!

src/main/java/com/fauna/client/QueryStatsSummary.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/client/QueryStatsSummary.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/client/QueryStatsSummary.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/client/QueryStatsSummary.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/client/QueryStatsSummary.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/response/QueryStats.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/response/QueryStats.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/response/QueryStats.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/response/QueryStats.java Outdated Show resolved Hide resolved
src/main/java/com/fauna/response/QueryStats.java Outdated Show resolved Hide resolved
@pnwpedro pnwpedro changed the title Add javadocs for query stats classes Add javadocs for response package Nov 6, 2024
@pnwpedro pnwpedro changed the title Add javadocs for response package Add javadocs for QueryStats Nov 6, 2024
@pnwpedro pnwpedro requested a review from jrodewig November 6, 2024 15:05
jrodewig
jrodewig approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@pnwpedro pnwpedro merged commit 3fe0910 into main Nov 6, 2024
1 check passed
@pnwpedro pnwpedro deleted the QueryStats-javadocs branch November 6, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodewig jrodewig jrodewig approved these changes

@findgriffin findgriffin Awaiting requested review from findgriffin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pnwpedro @jrodewig