fix: --max-backoff accepts seconds, not ms (#588)

fauna · Feb 7, 2025 · 37fbe45 · 37fbe45
1 parent 49016eb
commit 37fbe45
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/lib/options.mjs b/src/lib/options.mjs
@@ -143,7 +143,7 @@ export const QUERY_OPTIONS = {
   "max-backoff": {
     type: "number",
     description:
-      "Maximum backoff time (in milliseconds) between retry attempts. Only applies to v10 queries.",
+      "Maximum backoff time, in seconds, between retry attempts. Only applies to v10 queries.",
     default: undefined,
     group: "API:",
   },

diff --git a/test/commands/query/v10.mjs b/test/commands/query/v10.mjs
@@ -124,7 +124,7 @@ describe("query v10", function () {
 
   it("can set various query options", async function () {
     await run(
-      `query "Database.all()" --secret=foo --typecheck --performance-hints --max-attempts 5 --max-backoff 2000 --timeout 10000 --max-contention-retries 3`,
+      `query "Database.all()" --secret=foo --typecheck --performance-hints --max-attempts 5 --max-backoff 2 --timeout 10000 --max-contention-retries 3`,
       container,
     );
 
@@ -135,7 +135,7 @@ describe("query v10", function () {
         typecheck: true,
         performanceHints: true,
         maxAttempts: 5,
-        maxBackoff: 2000,
+        maxBackoff: 2,
         maxContentionRetries: 3,
       }),
     );

diff --git a/test/commands/shell.mjs b/test/commands/shell.mjs
@@ -343,7 +343,7 @@ describe("shell", function () {
       let query = "Database.all().take(1)";
 
       const runPromise = run(
-        "shell --secret=foo --typecheck --performance-hints --max-attempts 5 --max-backoff 2000 --timeout 10000 --max-contention-retries 3",
+        "shell --secret=foo --typecheck --performance-hints --max-attempts 5 --max-backoff 2 --timeout 10000 --max-contention-retries 3",
         container,
       );
 
@@ -359,7 +359,7 @@ describe("shell", function () {
           typecheck: true,
           performanceHints: true,
           maxAttempts: 5,
-          maxBackoff: 2000,
+          maxBackoff: 2,
           maxContentionRetries: 3,
         }),
       );