Redact any common secrets from fetch debug logging #553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When outputting to stderr with debugging functions, we do a best effort to redact any secrets printed. We do this to avoid users accidentally copying and pasting debug logging with live secrets from their local terminal to GitHub or other places.
The fetch logging wasn't being redacted.
Solution
Use the
redactedStringify
helper in the fetch wrapper. While we're here:Result
Fetch debug logging will redact anything that we think is a secret:
Testing
Unit tests were updated for redact.