Implement retry options #575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FE-6286
Problem
We do not expose the following query options to users:
max_attemptsmax_backoffThe contention retries and throttling retries are slightly separate concerns, but I got confused and ended up with both sets of additional options in this PR.
Solution
Add the options to the
QUERY_OPTIONSconstant and pipe them into v4 and v10 queries.The v4 driver does not have an explicit option for configuring the
x-fauna-max-contention-retriesheader, but it does accept an object with headers that are included with the query.Testing
Added/updated tests to show we're passing the options to the drivers.