Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE-6300 Accept S3 URI as input for export and show S3 URI in output. #584

Merged
merged 5 commits into from
Jan 27, 2025

Conversation

cleve-fauna
Copy link
Contributor

@cleve-fauna cleve-fauna commented Jan 24, 2025

Problem

We got some feedback that exports would be easier to work with if you could input an S3 URI as the desired destination.

As a result our account API was updated to:

  1. accept a URI as input
  2. always output the destination uri as output.

The output objects now look like:

{
   ...rest,
   destination: {
     s3: { bucket: "b", path: "p" },
     uri: "s3://b/p",
   }
}

Solution

This commit updates the CLI :

  • to accept S3 URIs as destination inputs for exports.
  • always output the output object that includes a uri field on destionation
  • have list use the provided destination.uri rather than constructing one.

Result

CLI isn't reinventing what the API is already doing.

Testing

Ran the full suite.
Did some end to end export create, lists and gets with the updated code.

@cleve-fauna cleve-fauna changed the title FE-6300 Accept s3 URI as input for export and show s3 URI in output. FE-6300 Accept S3 URI as input for export and show S3 URI in output. Jan 27, 2025
@cleve-fauna cleve-fauna marked this pull request as ready for review January 27, 2025 15:08
@cleve-fauna cleve-fauna requested a review from a team as a code owner January 27, 2025 15:08
src/commands/export/create.mjs Show resolved Hide resolved
@cleve-fauna cleve-fauna merged commit ea81a92 into main Jan 27, 2025
4 checks passed
@cleve-fauna cleve-fauna deleted the main_exportUrlIsTerm branch January 27, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants