Support idempotency on create export in the CLI. #585
Merged
+153
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
POST /v2/exports
API supports idempotency, but this is not exposed in the CLI.Solution
Expose it in the CLI for
fauna export create
via an optional--idempotency
argumentResult
Customers can create idempotent exports if they desire.
Testing
Ran the tests also ran with the idempotency command locally against the production API.
You can see that:
--idempotency
is properly handled (idempotent_replayed: false
is in the output)idempotent_replayed: false
is in the output)idempotent_replayed: true
is in the output)This proves it works as a steal thread.