Various puppet-lint fixes #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Include classes by absolute name for Puppet 4 compatibility - Single quote strigs which have no variables - Change ::syslog_ng::config::content define's default value into undef Signed-off-by: Samuli Seppänen <[email protected]>
Signed-off-by: Samuli Seppänen <[email protected]>
Use of this parameter avoids the need to hardcode the syslog-ng config directory path into external modules. Signed-off-by: Samuli Seppänen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits fix various warnings reported by puppet-lint.
A lot more warnings were reported, but I did not fix them yet. For example:
The indentation thing was the biggest complaint. Puppet-lint wants resources/classes to be called like this:
In case the formatting gets messed up, the arrows are supposed to be aligned on top of each either.
If you want, I can fix most of the remaining warnings too and send another pull request.
Best regards,
Samuli