-
Notifications
You must be signed in to change notification settings - Fork 0
Finish setup for v0.0.1 release #11
base: master
Are you sure you want to change the base?
Conversation
Public/private key mechanism and Google auth
Public/private key mechanism and Google auth
Added proper docs, inifite lifetime for token
Added proper docs, inifite lifetime for token
Circleci project setup
@@ -1,9 +0,0 @@ | |||
AUTH_TOKEN_SECRET=9385a8d9c0cbfbd54e8fc264a0f730ed1cbfe7678c8ad20d3ffd71384febef0f068d540e156e32262642f8aa08f38083ff31cdf2cc355bab5de95086c03cf3393392e021903a48183dd5f4c21609b6c7451f0de6333367eac13f5a4deac6ac203c0a8b6330cf1d0c8624cbc69b61cc700bcde6d88ebe5a0878bdab77664dc52b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this from git history
} | ||
|
||
async _fetchKeys() { | ||
this._privateKey = fs.readFileSync(path.join(__dirname, '../../../keys/private.pem'), 'utf8') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not destructure these paths into a const and use here ?
so when updating directories you don't have to change code but just changing variables will help
|
||
} | ||
|
||
module.exports = JWTHandler; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add newline at the end of the file, set that in your editorconfig so it adds by default
const mongoose = require('mongoose'); | ||
|
||
const userSchema = new mongoose.Schema({ | ||
first_name: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no rules for first name and last name length, empty .... ?
No description provided.