Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Finish setup for v0.0.1 release #11

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open

Finish setup for v0.0.1 release #11

wants to merge 42 commits into from

Conversation

fayaz07
Copy link
Owner

@fayaz07 fayaz07 commented Jun 18, 2020

No description provided.

fayaz07 added 30 commits April 13, 2020 12:59
Public/private key mechanism and Google auth
Public/private key mechanism and Google auth
@@ -1,9 +0,0 @@
AUTH_TOKEN_SECRET=9385a8d9c0cbfbd54e8fc264a0f730ed1cbfe7678c8ad20d3ffd71384febef0f068d540e156e32262642f8aa08f38083ff31cdf2cc355bab5de95086c03cf3393392e021903a48183dd5f4c21609b6c7451f0de6333367eac13f5a4deac6ac203c0a8b6330cf1d0c8624cbc69b61cc700bcde6d88ebe5a0878bdab77664dc52b
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this from git history

}

async _fetchKeys() {
this._privateKey = fs.readFileSync(path.join(__dirname, '../../../keys/private.pem'), 'utf8')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not destructure these paths into a const and use here ?

so when updating directories you don't have to change code but just changing variables will help


}

module.exports = JWTHandler;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add newline at the end of the file, set that in your editorconfig so it adds by default

const mongoose = require('mongoose');

const userSchema = new mongoose.Schema({
first_name: String,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no rules for first name and last name length, empty .... ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants