Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add Typescript #8

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: Add Typescript #8

wants to merge 1 commit into from

Conversation

martinzuern
Copy link

@martinzuern martinzuern commented Feb 7, 2020 •
edited
Loading

Refers #4

TODO:

  • Add tests
  • Update documentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2382ef2 on martinzuern:add-typescript into f223364 on fcurella:master.

@csabasulyok csabasulyok mentioned this pull request Mar 10, 2022
Open
fcurella
fcurella requested changes Mar 15, 2022
View reviewed changes
Copy link
Owner

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some test cases for TSX?

@cad0p cad0p mentioned this pull request Apr 11, 2023
Draft
andersk
andersk reviewed May 15, 2023
View reviewed changes
jsx/lexer.py
TOKENS["root"].insert(0, include("jsx"))
# Add tags and attributes support to existing tokens
def build_react_tokens(tokens):
tokens.update(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be fixed to avoid mutating dictionaries that don’t belong to us (see #20).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk andersk left review comments

@fcurella fcurella fcurella requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinzuern @coveralls @andersk @fcurella