-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend the 'per-device serviceinfo configuration' feature with files and commands #617
base: main
Are you sure you want to change the base?
Extend the 'per-device serviceinfo configuration' feature with files and commands #617
Conversation
Can we please have a description in PR, it's useful for justification etc. Also note we're moving to DB backends so I think this would be a better fit in the DB from a layout and performance PoV. I think also the commits could have better explanations rather than just "Update fileX". I'm going to set this to a draft. |
…ttps://github.com/RZandvoort/fido-device-onboard-rs into Add-per-device-files-configuration-implementation # Conflicts: # serviceinfo-api-server/src/main.rs
This pull request was supposed to be for trying stuff out, but then I accidentally clicked on the big green 'create PR' button. If we eventually could squash commit, it will look like nothing happend 🤐 |
The DB support has now landed so it will need to be part of that. I am going to convert this to a draft, once there is DB support and everything is squashed feel free to convert it back to ready then. |
0abfa80
to
38a1dd4
Compare
38a1dd4
to
6dbdee6
Compare
This reverts commit 1d13963.
Implemented the
files
andcommands
part of the per-device serviceinfo configuration feature:Configration example
Current example yml
New example yml
Per defices files:
It will write both base and per-device configured files.
If duplicate files are defined, it will choose the per-device file over the base file.
Per device commands:
Additional per device commands will be executed after the base commands