chore: move from tempdir to tempfile #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tempdir crate is obsolete - it has not been updated since 2017, and it has been officially marked as deprecated in RUSTSEC-2018-0017.
|
Thanks, we had been tracking this via #684 but no one had got to it yet. |
|
Builds fine locally |
nullr0ute
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tempdir crate is obsolete - it has not been updated since 2017, and it has been officially marked as deprecated in RUSTSEC-2018-0017, with the
tempfilecrate being an obvious replacement.It looks like only the "manufacturing-server" component still depends on
tempdir, everything else already depends on thetempfilecrate. Moving this workspace member totempfiletoo eliminates a lot of cruft from the lockfile, too.From what I can tell,
tempfile::TempDir::with_prefix(prefix)is a drop-in replacement fortempdir::TempDir::new(prefix).For context, I'm trying to drop the package for the
tempdircrate from Fedora Linux, and fido-device-onboard is one of the few remaining packages that pull it in.