Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lifetime bug #32

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Fix lifetime bug #32

merged 2 commits into from
Sep 28, 2023

Conversation

k0aki
Copy link
Contributor

@k0aki k0aki commented Sep 26, 2023

Fix lifetime bug introduced in graphviz PR: unjustified assumption about same lifetime on references nested in DisplaySignature and DisplayCalleeFuncRef type.

Copy link
Collaborator

@Y-Nak Y-Nak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Y-Nak
Copy link
Collaborator

Y-Nak commented Sep 26, 2023

@k0aki oops, I caused a conflict. Would you rebase the branch to the current master? Sorry.

@k0aki k0aki force-pushed the fix-lifetime-bug branch 2 times, most recently from 80da4e3 to 73217b8 Compare September 28, 2023 05:15
@Y-Nak
Copy link
Collaborator

Y-Nak commented Sep 28, 2023

👍 , thanks for rebasing!

@Y-Nak Y-Nak merged commit 963ecd8 into fe-lang:main Sep 28, 2023
9 checks passed
@k0aki k0aki deleted the fix-lifetime-bug branch September 28, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants