Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add $contains, $contained_by, and $overlap operators #236

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michalgm
Copy link

@michalgm michalgm commented Nov 11, 2019

Summary

Simply adds 3 new array-type operators to OPERATORS and whitelist, as well as documentation

  • Tell us about the problem your pull request is solving
    Currently, interacting with array-type fields would require complex and/or queries
  • Are there any open issues that are related to this?
    Issue Add array-type operators #235
  • Is this PR dependent on PRs in other repos?
    No

Other Information

Tested to confirm queries are written as expected

@daffl
Copy link
Member

daffl commented Nov 15, 2019

Thank you! Can we add tests for those as well?

@michalgm
Copy link
Author

michalgm commented Feb 6, 2020

Odd - could have sworn I commented on this back in November. I looked into adding tests, but since these features only apply to postgres, I couldn't see how to add a test without making postgres a dependency for testing, at least with the current test framework. I based the addition on the ilike operator, which is also postgrest-only. If you give me any pointers on how to properly add tests for these operators, I'm happy to look into it.

@JStuve
Copy link

JStuve commented Dec 20, 2020

Any update on a release for this feature? Works completely as expect and would like to have this officially!

@michalgm
Copy link
Author

Hi - checking in to see if I can get any guidance on what would be needed to get this merged? Thanks!

@carcinocron
Copy link

Any guidance on how to use this while we wait on it being merged?

@carcinocron
Copy link

this worked:

yarn add https://github.com/michalgm/feathers-knex#c3caff90a63d1bcd07e6f19994139f9ec7220471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants