Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add fsd-fipe sample #789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatheusMoura17
Copy link

Background

Add new sample

This project was created to practice the FSD. It integrates with the FIPE API to demonstrate the application of this methodology in a real-world scenario.

Staiger

image

@illright
Copy link
Member

illright commented Feb 4, 2025

Hi, thanks for the example and the Steiger screenshot! I looked over the project briefly, and it looks nice, one comment — I found the api segment of the filter-vehicle feature strange. Typically, the api segment is for code that communicates with external APIs, but in your case it contains a Zustand store and a URL search params wrapper — both things related to data storage. Typically, these things should go to model. Why did you choose to put them in api?

@illright
Copy link
Member

illright commented Feb 4, 2025

Oh, and also the app doesn't seem to be working for me:
image

Link: https://matheusmoura17.github.io/fsd-fipe/vehicle-value?type=carros&brand=3&model=6&year=2004-1

@MatheusMoura17
Copy link
Author

Hey @illright!

Thank you so much for taking the time to review this example!

Typically, these things should go to the model. Why did you choose to put them in the API?

You're right, I just confused some concepts while developing the project, and it ended up in the wrong place.
Fixed in MatheusMoura17/fsd-fipe#3

Oh, and also, the app doesn't seem to be working for me.

It was a conflict between github-pages and react-router. I made a change to use hash-router, and now everything is working as expected. You can try visiting the link below:
https://matheusmoura17.github.io/fsd-fipe/#/vehicle-value?type=carros&brand=43&model=1833&year=1994-1

You can see all the changes here: v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants