Feature/dotnet8 angular18 #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmblair
requested changes
Jun 10, 2024
README.md
Outdated
|
|
||
| | `dotnet new angular` | `dotnet new f23-angular-material` | | ||
| | --- | --- | | ||
| | ❌ Slow inner-loop dev experience with the proxy and HTTPS cert startup code | ✅ Fast inner-loop with separate processes for ASP.NET and `npm start` (see README in generated project) | | ||
| | ❌ Angular proxy code does not match how it's usually used when deployed to production | ✅ Closer match to production | | ||
| | ❌ Does an `npm install` on launch | ✅ Faster launch by letting you run `npm i` only when needed | | ||
| | ❌ Angular v12 | ✅ Angular v16 | | ||
| | ❌ Angular v12 | ✅ Angular v18 | |
There was a problem hiding this comment.
I don't think the ASP.NET built-in template uses a version as ancient as v12 any more, but I'm unsure what version it's currently on.
| @@ -34,8 +34,8 @@ | |||
| if (context.File.Name == "index.html") | |||
| { | |||
| // more info on this header: https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Cache-Control#preventing_caching | |||
| context.Context.Response.Headers.Add("Cache-Control", "no-store, max-age=0"); | |||
| context.Context.Response.Headers.Add("Expires", "-1"); | |||
| context.Context.Response.Headers.Append("Cache-Control", "no-store, max-age=0"); | |||
There was a problem hiding this comment.
I'm familiar with the warning this is addressing, but is Append appropriate here or should we be using the indexer to set (overwrite) the values if they already exist in the dictionary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MIgrate to .NET 8 and Angular 18. Fixes #4