Add capability to block user agents #5749
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbeaufort
reviewed
Mar 8, 2024
webservices/rest.py
Outdated
| @@ -176,6 +180,10 @@ def limit_remote_addr(): | |||
| if request_api_key_id not in BYPASS_RESTRICTION_API_KEY_IDS: | |||
| # Service unavailable | |||
| abort(503, RESTRICT_MESSAGE) | |||
| user_agent = request.headers.get('User-Agent') | |||
| for blocked_agent in BLOCKED_USER_AGENTS: | |||
There was a problem hiding this comment.
Should we check if there's a user agent before checking if it's a blocked user agent? It would save a step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary (required)
(Include a summary of proposed changes and connect issue below)
Required reviewers
(Include who is required to review prior to merge. For example: One designer and two front end developer reviews are required prior to merge)
Impacted areas of the application
General components of the application that this PR will affect:
Screenshots
(Include a screenshot of the new/updated features in context (“in the wild”). If it is an interface change, include both before and after screenshots)
Related PRs
Related PRs against other branches:
How to test
(Include any information that may be helpful to the reviewer(s). This might include links to sample pages to test or any local environmental setup that is unusual such as environment variable (never credentials), API version to point to, etc)
System architecture updates (if applicable)
(If this pull request changes our current system diagram, include a description of those changes here and create a new ticket to update the system diagram)