Add specific check for duplicate cat URLS #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously, if a user tried to create a category URL that already existed in a category, it was caught as a SQLALCHEMY integrity error, and the application did not crash. However we just printed the exception to the logs, and it looked like an error. This commit adds some error checking to see if the URL already exitst, and informs the user as such. Resolves: fedora-infra#317 Signed-off-by: Ryan Lerch <[email protected]>
abompard
force-pushed
the
master
branch
4 times, most recently
from
861f200 to
d9d0078
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, if a user tried to create a category URL that already existed in a category, it was caught as a SQLALCHEMY integrity error, and the application did not crash. However we just printed the exception to the logs, and it looked like an error. This commit adds some error checking to see if the URL already exitst, and informs the user as such.
Resolves: #317