Pagination #391
Pagination #391
Conversation
fix a few issues with the vagrant setup nnot working Signed-off-by: Ryan Lerch <[email protected]>
this will make it easier in the future when we introduce pagination Signed-off-by: Ryan Lerch <[email protected]>
ryanlerch
force-pushed
the
pagination
branch
from
010f029 to
4bb666a
Compare
|
All issues should be resolved now and ready for re-review. |
ryanlerch
force-pushed
the
pagination
branch
from
4bb666a to
e325583
Compare
mirrormanager2/views.py
Outdated
| default_page_size = flask.current_app.config["ITEMS_PER_PAGE"] | ||
| try: | ||
| page_number = int(flask.request.args.get("page_number")) | ||
| except (TypeError, ValueError): | ||
| page_number = 1 | ||
|
|
||
| try: | ||
| page_size = int(flask.request.args.get("page_size", default_page_size)) | ||
| except (TypeError, ValueError): | ||
| page_size = default_page_size | ||
|
|
There was a problem hiding this comment.
If you ever want to reuse the PaginationArgs dataclass in another view, you'll have to repeat this conversion block. So I would put that in the constructor of the PaginationArgs class (I think you can do something like that with dataclasses). The aim would be to just pass it flask.request.args.get("page_number") and flask.request.args.get("page_size") and let it do the conversion.
Since it's already a flask-specific class, we could even go as far as letting it set those attributes itself, by having it inspect flask.request. This way we'll have less repetition of code without sacrificing the abstraction layer! :-)
There was a problem hiding this comment.
Thanks yeah i thought about this but didnt investigate if it was possible with dataclasses -- looked at using post_init in dataclasses, but since we are really just setting ti all ourselves in the dataclass itself, i just defined my own init in the dataclass with the logic that previously was in the veiw endpoint.
also added a {posargs} to the lint env in tox so i can -- --fix
Resolves: fedora-infra#346 Signed-off-by: Ryan Lerch <[email protected]>
ryanlerch
force-pushed
the
pagination
branch
from
e325583 to
e2d3869
Compare
No description provided.