Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add greenlet module in the dependency #107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdglitched
Copy link
Contributor

Took the liberty to add the greenlet module in the dependencies to fix issue #106 – now the database initializes smoothly!

Screenshot From 2024-11-11 20-03-10

@gridhead gridhead requested a review from abompard November 12, 2024 12:49
@gridhead gridhead self-assigned this Nov 12, 2024
@gridhead gridhead self-requested a review November 12, 2024 12:49
Copy link
Member

@abompard abompard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use greenlet ourselves, so I don't think it's the right fix to add it to our dependencies.
I think we should depend on sqlalchemy[asyncio], the extra is going to bring in greenlet and it's what we're actually using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants