Broker class and necessary configuration

[brngylni]

Regarding to #14 @abompard

[gridhead]

I see that you are using the INI-styled configuration here. Could you please include a default configuration with placeholder values for folks to get started with?

[gridhead]

Also, @abompard should we stick to an INI-styled configuration or use a more profound TOML-styled configuration? I am fine with either but I wanted to hear your opinion on this.

[abompard]

We shouldn't use pydantic anyway, because Flask has its own configuration system.

[gridhead]

Yeah, I got bamboozled seeing all the Pydantic stuff here and assumed that it was used here.

[brngylni]

I see that you are using the INI-styled configuration here. Could you please include a default configuration with placeholder values for folks to get started with?

Default configuration for constants as a different file? Or should this one stay the same and just an example config as a different file?

[gridhead]

@brngylni Please refer to #2 (comment) for how commit messages should be written.

[gridhead]

@abompard, this is not in @brngylni's changes but can we please use context-aware modules for storing configuration instead of global variables?

Take for instance, the section https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/16/files#diff-00c1df60e290e533baec34ac9f6abd4db0fa8b99f04485315dff43023f8049b6R44-R47, could simply be a module-wide variable that can be referenced and changed throughout the project with the use of the following.

In the configuration initialization module named something.py,

from webhook_to_fedora_messaging import config

config.some_variable = "SOMETHING"

In the configuration using module named something_else.py,

from webhook_to_fedora_messaging import config

def do_something() -> str:
    return config.some_variable

As long as we do not import the variable like the following cases.

In the configuration initialization module named something.py,

from webhook_to_fedora_messaging.config import some_variable

some_variable = "SOMETHING"

In the configuration using module named something_else.py,

from webhook_to_fedora_messaging.config import some_variable

def do_something() -> str:
    return some_variable

We should be able to ensure that the variable is not instantiated with the default value and that the variable retains the value set to it during the runtime.

[brngylni]

@abompard, this is not in @brngylni's changes but can we please use context-aware modules for storing configuration instead of global variables?

Take for instance, the section https://github.com/fedora-infra/webhook-to-fedora-messaging/pull/16/files#diff-00c1df60e290e533baec34ac9f6abd4db0fa8b99f04485315dff43023f8049b6R44-R47, could simply be a module-wide variable that can be referenced and changed throughout the project with the use of the following.

In the configuration initialization module named something.py,

from webhook_to_fedora_messaging import config

config.some_variable = "SOMETHING"

In the configuration using module named something_else.py,

from webhook_to_fedora_messaging import config

def do_something() -> str:
    return config.some_variable

As long as we do not import the variable like the following cases.

In the configuration initialization module named something.py,

from webhook_to_fedora_messaging.config import some_variable

some_variable = "SOMETHING"

In the configuration using module named something_else.py,

from webhook_to_fedora_messaging.config import some_variable

def do_something() -> str:
    return some_variable

We should be able to ensure that the variable is not instantiated with the default value and that the variable retains the value set to it during the runtime.

I can switch the structure to this if you both agreed on this @abompard @gridhead