Extends tests for ModuleStream.depends_on_stream() #203
Conversation
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists Replicates the existing python tests, and newly added tests for depends_on_stream to C. Fixes : fedora-modularity#192 related: fedora-modularity#199
There was a problem hiding this comment.
I think you misunderstood the requirement here. Issue #192 is about dealing with a YAML document that includes a streamname: [] block under the dependencies.
| @@ -1035,8 +1034,16 @@ def test_depends_on_stream(self): | |||
| stream.build_depends_on_stream( | |||
| 'platform', 'f28'), False) | |||
|
|
|||
| self.assertEqual(stream.depends_on_stream('base', 'f30'), False) | |||
| self.assertEqual(stream.depends_on_stream('base', 'f30'), False) | |||
There was a problem hiding this comment.
Why are you removing these two tests? Though, the second one should have been stream.build_depends_on_stream(), That's a bug in the original code here.
| @@ -682,7 +682,6 @@ def test_v2_yaml(self): | |||
|
|
|||
| assert 'rawhide' in stream.get_servicelevel_names() | |||
| assert 'production' in stream.get_servicelevel_names() | |||
|
|
|||
| self.assertEqual(stream.depends_on_stream('base', 'f30'), False) | ||
| self.assertEqual( | ||
| stream.depends_on_stream( | ||
| 'base', ''), False) |
There was a problem hiding this comment.
I think you misunderstood the requirement here. We don't need tests for a stream name being the empty string. We need a new requires/buildrequires in the v2 YAML document. Something like perl in:
dependencies:
- buildrequires:
platform: [ f30 ]
perl: []
requires:
platform: [ -f28 ]
perl: []
This test is ONLY for ModuleStreamV2, since there is no way to represent this in the ModuleStreamV1 YAML.
|
Tracking this in #210 Please do not file new PRs each time. Just update the current one by pushing to this branch. |
The tests for depends_on_stream() and build_depends_on_stream() is modified to handle empty lists
Replicates the existing python tests, and newly added tests for depends_on_stream to C.
Fixes : #192
related: #199