Fix XMD comparison #303
Merged
Fix XMD comparison #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparison of the XMDs were accidentally returning the opposite truth value. Signed-off-by: Stephen Gallagher <[email protected]>
|
Note that I didn't include a specific test for this fix, because it's covered by the merge tests once #304 lands. |
OrionStar25
approved these changes
May 22, 2019
|
Thanks for the review. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparison of the XMDs were accidentally returning the opposite
truth value.
Signed-off-by: Stephen Gallagher [email protected]
@OrionStar25 please review. I discovered this while working on #188.