Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy Python tests for Modulemd.ModuleStream.v2_yaml into C #424

Merged
merged 1 commit into from
Jan 23, 2020
Merged

Copy Python tests for Modulemd.ModuleStream.v2_yaml into C #424

merged 1 commit into from
Jan 23, 2020

Conversation

srikavin
Copy link
Contributor

This is related to #199.

I've copied over the majority of this test into C, but I am unsure how to use GVariant to reimplement the XMD tests in the python version. How should I proceed?

@srikavin
Copy link
Contributor Author

I figured out how to implement the GVariant portion of the test, and I have copied over the entirety of the test. I'm looking forward to any feedback!

Copy link
Member

@OrionStar25 OrionStar25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sgallagher added a commit that referenced this pull request Jan 23, 2020
Copy Python tests for Modulemd.ModuleStream.v2_yaml into C

Signed-off-by: Stephen Gallagher <[email protected]>
@sgallagher sgallagher merged commit a20a3f2 into fedora-modularity:master Jan 23, 2020
@srikavin srikavin deleted the test-v2-yaml branch February 1, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants