Skip to content

Commit

Permalink
Do not print error from GetPodContainers to user
Browse files Browse the repository at this point in the history
Log the error to the dump.log file, but do not bother the user, as she
can't act upon that error.
  • Loading branch information
rhcarvalho committed Sep 16, 2016
1 parent 5baa3ca commit a25aad3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ func GetPodContainers(runner Runner, project, name string) ([]string, error) {
if err := runner.Run(cmd, filepath.Join("projects", project, "pods", name, "container-names")); err != nil {
return nil, err
}
return readSpaceSeparated(&b)
names, err := readSpaceSeparated(&b)
return names, MarkErrorAsIgnorable(err)
}

// FetchLogs is a task factory for tasks that fetch the logs of a
Expand Down

0 comments on commit a25aad3

Please sign in to comment.