This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
typo of window.fetchWithAuth #3
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,4 @@ | ||
/* global fetchWithAuth */ | ||
|
||
import Component from 'inferno-component'; | ||
import Component from 'inferno-component'; | ||
|
||
class QuestionViewer extends Component { | ||
state = { | ||
|
@@ -10,7 +8,7 @@ class QuestionViewer extends Component { | |
} | ||
async componentDidMount() { | ||
const { qno } = this.props.params; | ||
var res = await fetchWithAuth(`/questions/${qno}`); | ||
var res = await window.fetchWithAuth(`/questions/${qno}`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Make a commit with only this line |
||
res = await res.json(); | ||
if (!res.error) this.setState({ question: res, loading: false }) | ||
else this.setState({ error: res.error, loading: false }) | ||
|
@@ -25,8 +23,9 @@ class QuestionViewer extends Component { | |
<p> | ||
{question.body} | ||
</p> | ||
{/* XXX: Need to add previous and next buttons here. Use the Link component from 'inferno-router' */} | ||
<input type="button" class="next" value="NEXT"/> <input type="button" class="prev" value="PREVIOUS"/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This wont do anything until you bind these buttons or have them as links |
||
</div> | ||
|
||
) | ||
} | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this code? This is not backend :p